Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-540086: Missing critical areas for code coverage #873

Merged
merged 3 commits into from
Aug 4, 2023
Merged

SNOW-540086: Missing critical areas for code coverage #873

merged 3 commits into from
Aug 4, 2023

Conversation

sfc-gh-ext-simba-lb
Copy link
Contributor

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb commented Aug 2, 2023 •
edited
Loading

Description

Rename test_util.go so that it's excluded from code coverage. It's only used for tests.
Add AuthTypeTokenAccessor to determineAuthenticatorType() so it can be parsed in the DSN.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb requested a review from a team as a code owner August 2, 2023 15:48
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb force-pushed the codeCovMissingAreas branch 2 times, most recently from 9b378df to 7597a8f Compare August 2, 2023 19:46
@sfc-gh-ext-simba-lb
cover missing test areas
75582d7 
fix heartbeat test

remove heartbeat test
sfc-gh-igarish
sfc-gh-igarish approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-pfus
sfc-gh-pfus reviewed Aug 4, 2023
View reviewed changes
put_get_test.go Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb merged commit ad2d6fe into master Aug 4, 2023
21 checks passed
@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb deleted the codeCovMissingAreas branch August 4, 2023 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-lb @sfc-gh-igarish @sfc-gh-pfus