Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-207403 pin virtualenv until issue is fixed upstream #474

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

sfc-gh-mkeller
Copy link
Collaborator

This is the short term solution to fix the new behaviour by virtualenv

@sfc-gh-hchaturvedi
Copy link
Collaborator

It would be great if you can explain in a little more detail what is the new behavior and how it disrupts the test. Another thing, I'd like to believe that since it's only the virtualenv version we're pinning which essentially is used for test environments, it should not affect any community user unless they end up running tests and have dependency mismatch?

@sfc-gh-mkeller
Copy link
Collaborator Author

It would be great if you can explain in a little more detail what is the new behavior and how it disrupts the test. Another thing, I'd like to believe that since it's only the virtualenv version we're pinning which essentially is used for test environments, it should not affect any community user unless they end up running tests and have dependency mismatch?

I'm still investigating what caused this unexpected behaviour change. In the newest release they introduced a redirector script for Windows and Python 3.7 and above to align with how venv works. Docs for venv: https://docs.python.org/3/library/venv.html

This is a short term fix, you can follow my issue with virtualenv here: pypa/virtualenv#1981

I will be sharing my findings with you once I figured out what is going on but until then this will unblock PRs.

Copy link
Collaborator

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As confirmed with Mark this should not affect the customers as the change is only within the test setup.

Copy link

@sfc-gh-sshankar sfc-gh-sshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval

@sfc-gh-sshankar sfc-gh-sshankar merged commit 52fba87 into master Oct 14, 2020
@sfc-gh-sshankar sfc-gh-sshankar deleted the mkeller-SNOW-207403-pin_virtualenv branch October 14, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants