Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1374896 unify structured types string representation #1882

Merged
merged 38 commits into from
Sep 27, 2024
Merged

SNOW-1374896 unify structured types string representation #1882

merged 38 commits into from
Sep 27, 2024

Commits on Aug 22, 2024

  1. Refactor init converters for reuse in other code

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d8faeba View commit details
    Browse the repository at this point in the history

  2. Formatting

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8499a52 View commit details
    Browse the repository at this point in the history

  3. Removed star imports

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    982b13e View commit details
    Browse the repository at this point in the history

  4. Documentation style fix

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c82e155 View commit details
    Browse the repository at this point in the history

  5. Moved init converters to an already public class

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7a8382b View commit details
    Browse the repository at this point in the history

  6. Moved init converters to an appropriate interface

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7aa57d1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into init-converters-refactor

    @sfc-gh-astachowski
    sfc-gh-astachowski authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7246575 View commit details
    Browse the repository at this point in the history

  8. Changed the version of japicmp to include a needed bugfix

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    48c2435 View commit details
    Browse the repository at this point in the history

  9. Refactored unnecessary static modifiers

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6142094 View commit details
    Browse the repository at this point in the history

  10. Reformat

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a9ca5e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Update japicmp to the newest version

    @sfc-gh-astachowski
    sfc-gh-astachowski committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e1c69e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Merge branch 'master' into init-converters-refactor

    @sfc-gh-astachowski
    sfc-gh-astachowski authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d9701bc View commit details
    Browse the repository at this point in the history

  2. Implement FieldVector-based toString for structured types 

    Add helper ArrowStringRepresentationBuilders that take care of converting recursive toString results into a valid json, taking logical type into accunt. Extract fetching logical type from field metadata to a separate static function, change boolean string representations to lowercase, add tests.
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c63d35a View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. fix formatting

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    777c7d0 View commit details
    Browse the repository at this point in the history

  2. mark new classes as internal

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5ee4904 View commit details
    Browse the repository at this point in the history

  3. fix failing boolean test, remove integer from quotable types

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    655df20 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Address review comments 

    Move prefix and suffix cofiguration to the constructor of base builder, remove unnecessary comments, extract shouldQuote check to a super method, make valueType a constructor parameter for Array toString builder, fix tests failing due to the lowercase booleans
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4d2eb63 View commit details
    Browse the repository at this point in the history

  2. Refactor init converters for reuse in other code

    @sfc-gh-astachowski @sfc-gh-mkubik
    sfc-gh-astachowski authored and sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3a6dd28 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @sfc-gh-astachowski @sfc-gh-mkubik
    sfc-gh-astachowski authored and sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7668307 View commit details
    Browse the repository at this point in the history

  4. Removed star imports

    @sfc-gh-astachowski @sfc-gh-mkubik
    sfc-gh-astachowski authored and sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9d41eb5 View commit details
    Browse the repository at this point in the history

  5. Documentation style fix

    @sfc-gh-astachowski @sfc-gh-mkubik
    sfc-gh-astachowski authored and sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0c72b4b View commit details
    Browse the repository at this point in the history

  6. Moved init converters to an already public class

    @sfc-gh-astachowski @sfc-gh-mkubik
    sfc-gh-astachowski authored and sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9c325b9 View commit details
    Browse the repository at this point in the history

  7. Implement FieldVector-based toString for structured types 

    Add helper ArrowStringRepresentationBuilders that take care of converting recursive toString results into a valid json, taking logical type into accunt. Extract fetching logical type from field metadata to a separate static function, change boolean string representations to lowercase, add tests.
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e7397ee View commit details
    Browse the repository at this point in the history

  8. fix formatting

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ac7eb94 View commit details
    Browse the repository at this point in the history

  9. mark new classes as internal

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6c6df45 View commit details
    Browse the repository at this point in the history

  10. fix failing boolean test, remove integer from quotable types

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c74f967 View commit details
    Browse the repository at this point in the history

  11. Address review comments 

    Move prefix and suffix cofiguration to the constructor of base builder, remove unnecessary comments, extract shouldQuote check to a super method, make valueType a constructor parameter for Array toString builder, fix tests failing due to the lowercase booleans
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    11be102 View commit details
    Browse the repository at this point in the history

  12. Resolve merge conflicts

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    277ffab View commit details
    Browse the repository at this point in the history

  13. remove unnecessary toString override from child builder classes

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    67f3668 View commit details
    Browse the repository at this point in the history

  14. remove unnecessary shouldQuote call

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9a2c931 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. use StringJoiner instead of StringBuilder inside ArrowStringRepresent… 

    …ationBuilder
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2f96b68 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. resolve merge conflicts

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4f2bb5c View commit details
    Browse the repository at this point in the history

  2. Fix usages of ArrowVectorConverter utils after moving to a separate c… 

    …lass
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9887f74 View commit details
    Browse the repository at this point in the history

  3. fix formatting

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    542180d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'master' of github.com:snowflakedb/snowflake-jdbc into S… 

    …NOW-1374896-unify-structured-types-string-representation
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6e4d4b5 View commit details
    Browse the repository at this point in the history

  2. Add tests for AllTypesClass and NestedStructures 

    Assert correct string conversion for AllTypesClass and NestedStruct in ResultSetStructuredTypesLatestIT
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    31489f8 View commit details
    Browse the repository at this point in the history

  3. uncomment timezone ntz assert that was disabled for local testing

    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    581968d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. comment back the TODO comments from another tasks since they were bre… 

    …aking jenkins build
    @sfc-gh-mkubik
    sfc-gh-mkubik committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    97ac99a View commit details
    Browse the repository at this point in the history