Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1320449: Support subtracting two timestamps to get a timedelta. #2113

Merged

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Aug 16, 2024

Fixes SNOW-1320449

@sfc-gh-mvashishtha sfc-gh-mvashishtha added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Aug 16, 2024
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha force-pushed the mvashishtha/SNOW-1320449/subtract-two-timestamps branch from f47ec9e to bd8caf1 Compare August 16, 2024 18:43
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review August 16, 2024 20:07
@sfc-gh-mvashishtha sfc-gh-mvashishtha requested a review from a team as a code owner August 16, 2024 20:07
@sfc-gh-azhan
Copy link
Collaborator

Please rebase and then I'll take a pass thanks!

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sfc-gh-mvashishtha, just some minor nits

CHANGELOG.md Outdated Show resolved Hide resolved
src/snowflake/snowpark/modin/plugin/_internal/frame.py Outdated Show resolved Hide resolved
tests/integ/modin/binary/test_binary_op.py Outdated Show resolved Hide resolved
tests/integ/modin/binary/test_binary_op.py Outdated Show resolved Hide resolved
sfc-gh-mvashishtha and others added 5 commits August 20, 2024 10:49
Co-authored-by: Naren Krishna <naren.krishna@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title SNOW-1320449: Support subtracting two timestamps. SNOW-1320449: Support subtracting two timestamps to get a timedelta. Aug 20, 2024
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha enabled auto-merge (squash) August 21, 2024 00:14
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit d4b4638 into main Aug 21, 2024
35 checks passed
@sfc-gh-mvashishtha sfc-gh-mvashishtha deleted the mvashishtha/SNOW-1320449/subtract-two-timestamps branch August 21, 2024 03:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants