SNOW-1569916: fix local testing default timestamp timezone issue #2114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1569916
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
in snowflake, the default timestamp type is controlled by the session parameter
TIMESTAMP_TYPE_MAPPING
:https://docs.snowflake.com/en/sql-reference/parameters#label-timestamp-type-mapping
in local testing, we didn't have this testing, leaving the default timestamp type timezone information is empty.
this leads to incorrect behavior when users are using convert_timezone method.
this PR introduces a private module variable
TIMESTAMP_TYPE_MAPPING
as a temporary workaround to align with the default snowflake behavior -- whento_timestamp
is called, the timestamp should have timezone type being NTZ.this PR also added coercion for default timezone type and NTZ timezone type.