Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1458123 Implement Index is_numeric, is_integer, is_boolean, is_floating, and is_object #2146

Merged
merged 7 commits into from
Aug 22, 2024
Merged

SNOW-1458123 Implement Index is_numeric, is_integer, is_boolean, is_floating, and is_object #2146

merged 7 commits into from
Aug 22, 2024

Conversation

sfc-gh-vbudati
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1458123

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

Implemented Index is_numeric, is_integer, is_boolean, is_floating, and is_object.

@sfc-gh-vbudati sfc-gh-vbudati requested a review from a team as a code owner August 21, 2024 23:24
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sfc-gh-azhan
sfc-gh-azhan requested changes Aug 22, 2024
View reviewed changes
docs/source/modin/indexing.rst Outdated
@@ -62,7 +62,6 @@ Index
Index.is_boolean
Index.is_floating
Index.is_integer
Index.is_interval
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because I accidentally added this a long time ago -- this is not in the scope of the APIs we wanted to implement, even before we reduced the number of Index APIs to be implemented

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it there. It was displayed correctly as a not implemented one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't generally include docstring stubs for methods we haven't implemented, but I think we should keep it in the supported doc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense. Let's at least keep it in the supported doc then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back

docs/source/modin/supported/index_supported.rst Show resolved Hide resolved
@snowflakedb snowflakedb deleted a comment from noloerino Aug 22, 2024
sfc-gh-azhan
sfc-gh-azhan approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sfc-gh-vbudati sfc-gh-vbudati merged commit 93baaf8 into main Aug 22, 2024
35 checks passed
@sfc-gh-vbudati sfc-gh-vbudati deleted the vbudati/SNOW-1458123-index-is-type branch August 22, 2024 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay Awaiting requested review from sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-vbudati @sfc-gh-azhan @sfc-gh-joshi @sfc-gh-helmeleegy