FIX: Fix merge_asof test disabled sql simplifier
#2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naren Krishna <naren.krishna@snowflake.com>
sfc-gh-nkrishna
requested review from
sfc-gh-rdurrani and
sfc-gh-lmukhopadhyay
sfc-gh-nkrishna
changed the title
merge_asof test Jenkins CI
sfc-gh-nkrishna
added
NO-CHANGELOG-UPDATES
|
Kicked off daily run here: https://github.com/snowflakedb/snowpark-python/actions/runs/10529512019 |
sfc-gh-yzou
approved these changes
Aug 23, 2024
sfc-gh-yzou
reviewed
Aug 23, 2024
| ): | ||
| native_pd.merge_asof(left_native_df, right_native_df, on="a") | ||
| # Snowpark pandas raises a SnowparkSQLException | ||
| # MATCH_CONDITION clause is invalid: The left and right side expressions must be numeric or timestamp expressions. | ||
| with pytest.raises( | ||
| SnowparkSQLException, | ||
| ): | ||
| pd.merge_asof(left_snow_df, right_snow_df, on="a") | ||
| pd.merge_asof(left_snow_df, right_snow_df, on="a").to_pandas() |
There was a problem hiding this comment.
@sfc-gh-nkrishna are those test skipped in the merge gate? how com it didn't fail in the merge gate?
There was a problem hiding this comment.
Yeah I'm not sure about that as well, it shouldn't be skipped....
There was a problem hiding this comment.
They failed when the SQL optimizer was disabled which only run in github daily.
There was a problem hiding this comment.
@sfc-gh-azhan do you mean SqlSimpflication?
There was a problem hiding this comment.
that kind of make sense, the sql simplification tiggers an describing call when extracting ColumnState for select, that could explain it
sfc-gh-azhan
changed the title
merge_asof test Jenkins CImerge_asof test disabled sql simplifier
sfc-gh-azhan
approved these changes
Aug 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.