Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1638059: fix daily precommit failure test #2158

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Aug 23, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1638059

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

IMHO the two test cases are not be here, so removing them is the right approach here:

  1. test_async_place_holder, show functions causes flakiness because new functions can be created while the test is running, leading to chances of flakiness.
    also we have a bunch of async tests, I don't think we need this place holder any more, deleting the test should not reduce test coverage

  2. test_sql , sql describe result last_query_id() is not static, the result depends on the last executed query affected by the dataframe evaluation.
    see: https://github.com/snowflakedb/snowpark-python/actions/runs/10506040722/job/29104987419, if pandas is not installed, the last query will be the df.count but if pandas is installed, last query will be df.to_pandas().

This leads to the test failure. I think using last query id is error-prone and we should remove it or replace it.

@sfc-gh-aling sfc-gh-aling changed the title SNOW-1638059: fix failure test SNOW-1638059: fix daily precommit failure test Aug 23, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review August 23, 2024 18:40
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner August 23, 2024 18:40
@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Aug 23, 2024
@sfc-gh-aling sfc-gh-aling merged commit 7b58eb0 into main Aug 26, 2024
34 of 35 checks passed
@sfc-gh-aling sfc-gh-aling deleted the aling/fix-daily-precommit-test branch August 26, 2024 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants