SNOW-1638059: fix daily precommit failure test #2158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1638059
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
IMHO the two test cases are not be here, so removing them is the right approach here:
test_async_place_holder
,show functions
causes flakiness because new functions can be created while the test is running, leading to chances of flakiness.also we have a bunch of async tests, I don't think we need this place holder any more, deleting the test should not reduce test coverage
test_sql
, sqldescribe result last_query_id()
is not static, the result depends on the last executed query affected by the dataframe evaluation.see: https://github.com/snowflakedb/snowpark-python/actions/runs/10506040722/job/29104987419, if pandas is not installed, the last query will be the
df.count
but if pandas is installed, last query will bedf.to_pandas()
.This leads to the test failure. I think using last query id is error-prone and we should remove it or replace it.