Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1663726 make temp table cleaner thread safe #2309

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Sep 17, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1663726

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Introduce a lock to TempTableAutoCleaner to protect ref_count_map.

@sfc-gh-aalam sfc-gh-aalam changed the base branch from main to aalam-SNOW-1663726-make-session-config-updates-thread-safe September 17, 2024 20:16
@sfc-gh-aalam
Copy link
Contributor Author

todo: update according to these changes - #2368

Copy link

github-actions bot commented Oct 2, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

github-actions bot commented Oct 2, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Base automatically changed from aalam-SNOW-1663726-make-session-config-updates-thread-safe to aalam-SNOW-1418523-make-internal-session-variables-thread-safe October 4, 2024 16:58
…ad-safe' into aalam-SNOW-1663726-make-temp-table-cleaner-thread-safe
Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Copy link

github-actions bot commented Oct 4, 2024

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@sfc-gh-aalam sfc-gh-aalam merged commit bd0528d into aalam-SNOW-1418523-make-internal-session-variables-thread-safe Oct 4, 2024
4 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1663726-make-temp-table-cleaner-thread-safe branch October 4, 2024 17:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants