-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIT-2372] map
function
#2378
base: main
Are you sure you want to change the base?
[SIT-2372] map
function
#2378
Conversation
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
1 similar comment
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
a6f18c7
to
e88eed7
Compare
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me... again.
the new approach of making mpa part of functions.py does not alter to much the original implementation.
e88eed7
to
d0b5377
Compare
807f352
to
ff6a853
Compare
src/snowflake/snowpark/functions.py
Outdated
] | ||
|
||
output_cols = [ | ||
col(f"${i + num_fields + 1}").alias(col_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
col(f"${i + num_fields + 1}").alias(col_name) | |
col(f"${i + num_fields + 1}").alias(col_name) # this is done to avoid collision with original table columns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the commit fbeaf06
f09f598
to
d66de96
Compare
07e0771
to
e7b90ad
Compare
66bbfa5
to
01bc7f3
Compare
Adds the `map` function to apply a Python function to each row of a DataFrame.
01bc7f3
to
82839cb
Compare
Adds the
map
function to apply a Python function to each row of a DataFrame.Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SIT-2372
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Adds the
map
function which applies a Python function to every row of aDataFrame
.