Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_query_generator for query generation test on each snowflake plan node #2407

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

sfc-gh-yzou
Copy link
Collaborator

@sfc-gh-yzou sfc-gh-yzou commented Oct 7, 2024

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  2. Please describe how your code solves the related issue.

  1. fix a bug in test_query_generator that is was repeated test the query generation on the same plan node
  2. use a copy for the alias_map to to use during resolve to avoid unexpected update of the alias map

@sfc-gh-yzou sfc-gh-yzou requested a review from a team as a code owner October 7, 2024 17:50
@sfc-gh-yzou sfc-gh-yzou added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Oct 7, 2024
@sfc-gh-yzou sfc-gh-yzou merged commit 6cd32de into main Oct 7, 2024
33 of 35 checks passed
@sfc-gh-yzou sfc-gh-yzou deleted the yzou-fix-test-query-counter branch October 7, 2024 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants