-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1360263: [Local Testing] Tests for several issues. #2410
Merged
sfc-gh-jrose
merged 21 commits into
main
from
jrose_snow_1668981_local_testing_tvdboom_fixes
Oct 10, 2024
Merged
SNOW-1360263: [Local Testing] Tests for several issues. #2410
sfc-gh-jrose
merged 21 commits into
main
from
jrose_snow_1668981_local_testing_tvdboom_fixes
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose_snow_1668981_local_testing_tvdboom_fixes
sfc-gh-jrose
changed the title
Jrose snow 1668981 local testing tvdboom fixes
SNOW-1668981: [Local Testing] Tests for several issues.
Oct 8, 2024
sfc-gh-jrose
changed the title
SNOW-1668981: [Local Testing] Tests for several issues.
SNOW-1360263: [Local Testing] Tests for several issues.
Oct 8, 2024
7 tasks
sfc-gh-aalam
approved these changes
Oct 8, 2024
sfc-gh-aling
reviewed
Oct 9, 2024
df = test_data.with_column("b", lit(None)) | ||
|
||
try: | ||
df.write.save_as_table(table_name=table_name, mode="truncate") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we validate the table after saving?
sfc-gh-jrose
commented
Oct 9, 2024
Comment on lines
93
to
96
@pytest.mark.skipif( | ||
not installed_pandas, | ||
reason="Test requires pandas.", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, will update.
sfc-gh-aling
approved these changes
Oct 9, 2024
sfc-gh-jrose
deleted the
jrose_snow_1668981_local_testing_tvdboom_fixes
branch
October 10, 2024 15:50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1360263
Fixes SNOW-1668862
Fixes SNOW-1694649
Fixes SNOW-1707286
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR adds tests to verify fixes proposed by community member @tvdboom.
Notes from their PR #2373:
jrose Notes:
SNOW-1668981: I've removed the fix for this from the original PR as it appears to also affect live mode and will need a larger change.
SNOW-1360263: The proposed change broke in some edge cases when I ran tests against it. I've amended this part of the change to extract the ordering from the rolling window operation instead.
SNOW-1668862, SNOW-1694649, SNOW-1707286: All look good as is.