Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1728471: Fix changelog entry placement for DataFrameGroupBy.fillna and SeriesGroupBy.fillna #2417

Merged
merged 2 commits into from
Oct 8, 2024
Merged

SNOW-1728471: Fix changelog entry placement for DataFrameGroupBy.fillna and SeriesGroupBy.fillna #2417

merged 2 commits into from
Oct 8, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy commented Oct 8, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1728471

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    Fix changelog entry placement for DataFrameGroupBy.fillna and SeriesGroupBy.fillna.

@sfc-gh-helmeleegy sfc-gh-helmeleegy added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Oct 8, 2024
sfc-gh-nkrishna
sfc-gh-nkrishna reviewed Oct 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sfc-gh-nkrishna
sfc-gh-nkrishna approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for catching!

@sfc-gh-helmeleegy sfc-gh-helmeleegy enabled auto-merge (squash) October 8, 2024 20:09
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 6555b0c into main Oct 8, 2024
34 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1728471 branch October 8, 2024 21:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna sfc-gh-nkrishna approved these changes

@sfc-gh-jjiao sfc-gh-jjiao sfc-gh-jjiao approved these changes

@sfc-gh-evandenberg sfc-gh-evandenberg Awaiting requested review from sfc-gh-evandenberg

Assignees
No one assigned
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-helmeleegy @sfc-gh-vbudati @sfc-gh-nkrishna @sfc-gh-jjiao