SNOW-1645316: Modularize skip lqb conditions and add no db check #2451
+100
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
added
the
NO-CHANGELOG-UPDATES
sfc-gh-aalam
requested review from
sfc-gh-jdu,
sfc-gh-yuwang and
sfc-gh-jrose
sfc-gh-yzou
reviewed
Oct 18, 2024
| self, | ||
| ) -> Optional[SkipLargeQueryBreakdownCategory]: | ||
| """Method to check if the optimization should be skipped based on the session state.""" | ||
| if self.session.get_current_database() is None: |
There was a problem hiding this comment.
how about schema? when there no current schema, that won't work also
There was a problem hiding this comment.
I tried to see if it is possible to get no schema. Snowflake automatically picks PUBLIC so I could create a scenario where there is no schema.
There was a problem hiding this comment.
added a check anyways.
sfc-gh-yzou
reviewed
Oct 18, 2024
| @@ -123,14 +123,14 @@ def __init__( | |||
| self.complexity_score_upper_bound = complexity_bounds[1] | |||
|
|
|||
| def apply(self) -> List[LogicalPlan]: | |||
| if is_active_transaction(self.session): | |||
| if reason := self._should_skip_optimization_for_session(): | |||
There was a problem hiding this comment.
let's just do
reason = self._should_skip_optimization_for_session()
if reason is not None:
xxx
easier for me to understand
| def _should_skip_optimization_for_session( | ||
| self, | ||
| ) -> Optional[SkipLargeQueryBreakdownCategory]: | ||
| """Method to check if the optimization should be skipped based on the session state.""" |
There was a problem hiding this comment.
add comment about the return value
sfc-gh-yzou
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1645316
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
i) Move skip large query breakdown into two functions:
_should_skip_optimization_for_session_should_skip_optimization_for_rootii) Add a condition to skip large query breakdown when no database exists