Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1690923 Encode Intervals #2454

Open
wants to merge 5 commits into
base: ls-SNOW-1491199-merge-phase0-server-side
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/snowflake/snowpark/_internal/analyzer/expression.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import uuid
from typing import TYPE_CHECKING, AbstractSet, Any, Dict, List, Optional, Tuple

import snowflake.snowpark._internal.proto.ast_pb2 as proto
import snowflake.snowpark._internal.utils
from snowflake.snowpark._internal.analyzer.query_plan_analysis_utils import (
PlanNodeCategory,
Expand Down Expand Up @@ -379,7 +380,10 @@ def __init__(
millisecond: Optional[int] = None,
microsecond: Optional[int] = None,
nanosecond: Optional[int] = None,
_emit_ast: bool = True,
) -> None:
from snowflake.snowpark._internal.ast_utils import with_src_position
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to import here to prevent circular imports issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far in the code, we tried to avoid building expressions directly. The reasoning was that Expressions should disappear as they're not a first-class entity in snowpark. Instead we chose an approach where always the caller (i.e. the function that creates Interval) creates the AST and assigns it to the expression if need be. I.e.,

def build_expr_from_snowpark_column_or_python_val(
    expr_builder: proto.Expr, value: ColumnOrLiteral
) -> None:
    """Copy from a Column object's AST, or copy a literal value into an AST expression.

    Args:
        ast (proto.Expr): A previously created Expr() IR entity intance to be filled
        value (ColumnOrLiteral): The value from which to populate the provided ast parameter.

    Raises:
        TypeError: The Expr provided should only be populated from a Snowpark Column with a valid _ast field or a literal value
    """
    if isinstance(value, snowflake.snowpark.Column):
        build_expr_from_snowpark_column(expr_builder, value)
    elif isinstance(value, VALID_PYTHON_TYPES_FOR_LITERAL_VALUE):
        build_expr_from_python_val(expr_builder, value)
    elif isinstance(value, Expression):
        # Expressions must be handled by caller.
        pass
    else:
        raise TypeError(f"{type(value)} is not a valid type for Column or literal AST.")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we prob. can move the AST logic to build_expr_from_snowpark_column_or_python_val and have an Interval case there. I don't think the original intention of snowpark was to use Interval directly, but rather the make_interval function.


super().__init__()
self.values_dict = {}
if year is not None:
Expand All @@ -405,6 +409,14 @@ def __init__(
if nanosecond is not None:
self.values_dict["NANOSECOND"] = nanosecond

if self._ast is None and _emit_ast:
expr = proto.Expr()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/snowpark-python/snowpark-python/src/snowflake/snowpark/_internal/analyzer/expression.py:413:26 - error: "Expr" is not a known member of module "snowflake.snowpark._internal.proto.ast_pb2" (reportGeneralTypeIssues)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you repro locally?

python -m tox -e pyright

It is saying you may need a new version:
"Please install the new version or set PYRIGHT_PYTHON_FORCE_VERSION to latest"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the same errors locally, I'm not sure what to do about the first error though. There's other parts of the code that use proto.Expr() as well so I'm not sure why it's erroring here

ast = with_src_position(expr.sp_interval)
# Set the AST values based on the values_dict.
for k, v in self.values_dict.items():
getattr(ast, k.lower()).value = v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to avoid indirection via getattr and use the values explicitly. It's much easier to read and reason about :)

self._ast = expr

@property
def sql(self) -> str:
return f"""INTERVAL '{",".join(f"{v} {k}" for k, v in self.values_dict.items())}'"""
Expand Down
887 changes: 442 additions & 445 deletions src/snowflake/snowpark/_internal/proto/ast_pb2.py

Large diffs are not rendered by default.

13 changes: 4 additions & 9 deletions src/snowflake/snowpark/_internal/proto/scalapb_pb2.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,16 @@
#

# Generated by the protocol buffer compiler. DO NOT EDIT!
# NO CHECKED-IN PROTOBUF GENCODE
# source: scalapb/scalapb.proto
# Protobuf Python Version: 5.28.2
# Protobuf Python Version: 4.25.3
"""Generated protocol buffer code."""
from google.protobuf import (
descriptor as _descriptor,
descriptor_pool as _descriptor_pool,
runtime_version as _runtime_version,
symbol_database as _symbol_database,
)
from google.protobuf.internal import builder as _builder

_runtime_version.ValidateProtobufRuntimeVersion(
_runtime_version.Domain.PUBLIC, 5, 28, 2, "", "scalapb/scalapb.proto"
)
# @@protoc_insertion_point(imports)

_sym_db = _symbol_database.Default()
Expand All @@ -32,12 +27,12 @@
_globals = globals()
_builder.BuildMessageAndEnumDescriptors(DESCRIPTOR, _globals)
_builder.BuildTopDescriptorsAndMessages(DESCRIPTOR, "scalapb.scalapb_pb2", _globals)
if not _descriptor._USE_C_DESCRIPTORS:
_globals["DESCRIPTOR"]._loaded_options = None
if _descriptor._USE_C_DESCRIPTORS == False:
_globals["DESCRIPTOR"]._options = None
_globals[
"DESCRIPTOR"
]._serialized_options = b'\n\017scalapb.optionsZ"scalapb.github.io/protobuf/scalapb\342?\023\n\017scalapb.options\020\001'
_globals["_PREPROCESSOROUTPUT_OPTIONSBYFILEENTRY"]._loaded_options = None
_globals["_PREPROCESSOROUTPUT_OPTIONSBYFILEENTRY"]._options = None
_globals["_PREPROCESSOROUTPUT_OPTIONSBYFILEENTRY"]._serialized_options = b"8\001"
_globals["_MATCHTYPE"]._serialized_start = 2994
_globals["_MATCHTYPE"]._serialized_end = 3044
Expand Down
4 changes: 4 additions & 0 deletions src/snowflake/snowpark/mock/_analyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
Expression,
FunctionExpression,
InExpression,
Interval,
Like,
ListAgg,
Literal,
Expand Down Expand Up @@ -464,6 +465,9 @@ def analyze(
expr.ignore_nulls,
)

if isinstance(expr, Interval):
return str(expr)

raise SnowparkClientExceptionMessages.PLAN_INVALID_TYPE(
str(expr)
) # pragma: no cover
Expand Down
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.agg.test
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ df4 = df.agg({"a": "count", "b": "sum"})

## EXPECTED ENCODED AST

CvcCCvQCCuUC8gXhAgq4Agq1AgplygJiChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBIhugIeChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBABEiG6Ah4KGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEAIKZcoCYgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSIboCHgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwQAxIhugIeChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBAECmXKAmIKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEiG6Ah4KGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEAESIboCHgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwQBBIICgYKAUEKAUIaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEgQKAmRmGAEiAggBCs4CCssCCrsC+gW3AgoHggIECgIIARKPAgqBAYoBfgoOGgwKCgoICgZzdGRkZXYaUIoBTQoLGgkKBwoFCgNjb2waIrIMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4SAWEiGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheIhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXgqGAYoBggEKEhoQCg4KDAoKc3RkZGV2X3BvcBpQigFNCgsaCQoHCgUKA2NvbBoisgwfChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIBYSIaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4iGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgUKA2RmMhgCIgIIAgqXAgqUAgqEAvoFgAIKB4ICBAoCCAES2AEKadIMZgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASIrIMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASAWESJLIMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASA21pbgpp0gxmChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIisgwfChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIBYhIksgwhChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIDbWF4EAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShgEgUKA2RmMxgDIgIIAwr+AQr7AQrrAfoF5wEKB4ICBAoCCAESvwEKugGKBLYBCkwSIrIMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISAWESJrIMIwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISBWNvdW50CkoSIrIMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISAWISJLIMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISA3N1bRIaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGIQARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISBQoDZGY0GAQiAggEEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
CvcCCvQCCuUC8gXhAgq4Agq1AgplygJiChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBIhugIeChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBABEiG6Ah4KGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEAIKZcoCYgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSIboCHgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwQAxIhugIeChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBAECmXKAmIKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEiG6Ah4KGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEAESIboCHgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwQBBIICgYKAUEKAUIaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEgQKAmRmGAEiAggBCs4CCssCCrsC+gW3AgoHggIECgIIARKPAgqBAYoBfgoOGgwKCgoICgZzdGRkZXYaUIoBTQoLGgkKBwoFCgNjb2waIroMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4SAWEiGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheIhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXgqGAYoBggEKEhoQCg4KDAoKc3RkZGV2X3BvcBpQigFNCgsaCQoHCgUKA2NvbBoiugwfChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIBYSIaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4iGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgUKA2RmMhgCIgIIAgqXAgqUAgqEAvoFgAIKB4ICBAoCCAES2AEKadoMZgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASIroMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASAWESJLoMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASA21pbgpp2gxmChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIiugwfChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIBYhIkugwhChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIDbWF4EAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShgEgUKA2RmMxgDIgIIAwr+AQr7AQrrAfoF5wEKB4ICBAoCCAESvwEKugGKBLYBCkwSIroMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISAWESJroMIwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISBWNvdW50CkoSIroMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISAWISJLoMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISA3N1bRIaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGIQARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGISBQoDZGY0GAQiAggEEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.collect.test
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ df.collect_nowait(statement_params={"SF_PARTNER": "FAKE_PARTNER"}, log_on_except

## EXPECTED ENCODED AST

CkMKQQoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCjMKMQonygYkCAEQARoCCAEyGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEgAYAiICCAIKCBIGCAMSAggCEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
CkMKQQoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCjMKMQonygYkCAEQARoCCAEyGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEgAYAiICCAIKCBIGCAMSAggCEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
CjEKLwolygYiEAEaAggBMhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIAGAQiAggECggSBggFEgIIBBABGhESDwoNCgVmaW5hbBADGAkgFCIEEAEYFw==
Ck8KTQpDygZACAEQARoCCAEyGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShgOhoKClNGX1BBUlRORVISDEZBS0VfUEFSVE5FUhIAGAYiAggGCggSBggHEgIIBhABGhESDwoNCgVmaW5hbBADGAkgFCIEEAEYFw==
Ck0KSwpBygY+GgIIASABMhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYjoaCgpTRl9QQVJUTkVSEgxGQUtFX1BBUlRORVISABgIIgIICAoIEgYICRICCAgQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
Expand Down
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.count.test
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ df.count(statement_params={"SF_PARTNER": "FAKE_PARTNER"}, block=False)

## EXPECTED ENCODED AST

CkMKQQoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCjEKLwol2gYiCAESAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBIAGAIiAggCCggSBggDEgIIAhABGhESDwoNCgVmaW5hbBADGAkgFCIEEAEYFw==
CkMKQQoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCjEKLwol2gYiCAESAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXBIAGAIiAggCCggSBggDEgIIAhABGhESDwoNCgVmaW5hbBADGAkgFCIEEAEYFw==
Ci8KLQoj2gYgEgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4SABgEIgIIBAoIEgYIBRICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
CksKSQo/2gY8EgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGAiGgoKU0ZfUEFSVE5FUhIMRkFLRV9QQVJUTkVSEgAYBiICCAYKCBIGCAcSAggGEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
EAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.count2.test
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ df.count(statement_params={"SF_PARTNER": "FAKE_PARTNER"}, block=False)

## EXPECTED ENCODED AST

CoYBCoMBCnXyBXIKKBImCiQKIgogCh5TTk9XUEFSS19URU1QX1RBQkxFXzA0T05GRThSWlISKhIoCiYKFQoFCgMiQSISCpoBBwoFCICAgAgYAQoNCgUKAyJCIhICaAEYARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF0SBAoCZGYYASICCAEKMQovCiXaBiIIARICCAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShfEgAYAiICCAIKCBIGCAMSAggCEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
CoYBCoMBCnXyBXIKKBImCiQKIgogCh5TTk9XUEFSS19URU1QX1RBQkxFXzRIUjRPMDRUV1ISKhIoCiYKFQoFCgMiQSISCpoBBwoFCICAgAgYAQoNCgUKAyJCIhICaAEYARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF0SBAoCZGYYASICCAEKMQovCiXaBiIIARICCAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShfEgAYAiICCAIKCBIGCAMSAggCEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
Ci8KLQoj2gYgEgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGESABgEIgIIBAoIEgYIBRICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
CksKSQo/2gY8EgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGMiGgoKU0ZfUEFSVE5FUhIMRkFLRV9QQVJUTkVSEgAYBiICCAYKCBIGCAcSAggGEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
EAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.create_or_replace.test
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ res6 = df.create_or_replace_dynamic_table("test_dyn_table", warehouse="test_wh",

## EXPECTED ENCODED AST

CkMKQQoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBClwKWgpQ6gZNCgUKA2ZvbxIHggIECgIIASIHdGVzdF9kYiILdGVzdF9zY2hlbWEiCXRlc3RfdmlldyoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSABgCIgIIAgpLCkkKP+oGPBIHggIECgIIASIJdGVzdF92aWV3KhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXjIKCgNmb28SA2JhchIAGAMiAggDCl4KXApS6gZPCgUKA2ZvbxIHggIECgIIARgBIgd0ZXN0X2RiIgt0ZXN0X3NjaGVtYSIJdGVzdF92aWV3KhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIAGAQiAggECk0KSwpB6gY+EgeCAgQKAggBGAEiCXRlc3RfdmlldyoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGIyCgoDZm9vEgNiYXISABgFIgIIBQqdBAqaBAqPBNIGiwQKKgoFZm9yY2USIcIBHgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGgQARIHggIECgIIARoFZmlsZTEaBWZpbGUyIjQKC0NPTVBSRVNTSU9OEiWyDCIKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShoEgRHWklQIjYKEFJFQ09SRF9ERUxJTUlURVISIrIMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGgSAXwqCAoGW0EtWl0rMhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoaDoKCgNmb28SA2JhckIHdGVzdF9kYkILdGVzdF9zY2hlbWFCC3Rlc3RfdGFibGUySgFuSgNzdHJSlQHiApEBClCKAU0KCxoJCgcKBQoDY29sGiKyDB8KGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShuEgFuIhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobhIhugIeChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobhAKGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoblJSigFPCgsaCQoHCgUKA2NvbBoksgwhChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobhIDc3RyIhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobloPCg1SRVRVUk5fRVJST1JTEgAYBiICCAYKOQo3Cii6BiUKB4ICBAoCCAESGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSh0EgUKA2RmMxgHIgIIBwpFCkMKNLoGMQoHggIECgIIARIaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKHYaCgoDZm9vEgNiYXISBQoDZGY0GAgiAggIClwKWgpQ4gZNCgUKA2ZvbxIHggIECgIIARoGMSBob3VyIg50ZXN0X2R5bl90YWJsZSoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKHg6B3Rlc3Rfd2gSABgJIgIICRABGhESDwoNCgVmaW5hbBADGAkgFCIEEAEYFw==
CkMKQQoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBClwKWgpQ6gZNCgUKA2ZvbxIHggIECgIIASIHdGVzdF9kYiILdGVzdF9zY2hlbWEiCXRlc3RfdmlldyoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSABgCIgIIAgpLCkkKP+oGPBIHggIECgIIASIJdGVzdF92aWV3KhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXjIKCgNmb28SA2JhchIAGAMiAggDCl4KXApS6gZPCgUKA2ZvbxIHggIECgIIARgBIgd0ZXN0X2RiIgt0ZXN0X3NjaGVtYSIJdGVzdF92aWV3KhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIAGAQiAggECk0KSwpB6gY+EgeCAgQKAggBGAEiCXRlc3RfdmlldyoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGIyCgoDZm9vEgNiYXISABgFIgIIBQqdBAqaBAqPBNIGiwQKKgoFZm9yY2USIcIBHgoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGgQARIHggIECgIIARoFZmlsZTEaBWZpbGUyIjQKC0NPTVBSRVNTSU9OEiW6DCIKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShoEgRHWklQIjYKEFJFQ09SRF9ERUxJTUlURVISIroMHwoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGgSAXwqCAoGW0EtWl0rMhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoaDoKCgNmb28SA2JhckIHdGVzdF9kYkILdGVzdF9zY2hlbWFCC3Rlc3RfdGFibGUySgFuSgNzdHJSlQHiApEBClCKAU0KCxoJCgcKBQoDY29sGiK6DB8KGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShuEgFuIhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobhIhugIeChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobhAKGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoblJSigFPCgsaCQoHCgUKA2NvbBokugwhChoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobhIDc3RyIhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUobloPCg1SRVRVUk5fRVJST1JTEgAYBiICCAYKOQo3Cii6BiUKB4ICBAoCCAESGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSh0EgUKA2RmMxgHIgIIBwpFCkMKNLoGMQoHggIECgIIARIaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKHYaCgoDZm9vEgNiYXISBQoDZGY0GAgiAggIClwKWgpQ4gZNCgUKA2ZvbxIHggIECgIIARoGMSBob3VyIg50ZXN0X2R5bl90YWJsZSoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKHg6B3Rlc3Rfd2gSABgJIgIICRABGhESDwoNCgVmaW5hbBADGAkgFCIEEAEYFw==
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.cross_join.lsuffix.test
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ res2 = df1.cross_join(df2, lsuffix="_t1").select("*")

## EXPECTED ENCODED AST

CkQKQgoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgUKA2RmMRgBIgIIAQpECkIKM+ILMBIOCgwKCnRlc3RfdGFibGUaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIgIIARIFCgNkZjIYAiICCAIKRApCCjjyBjUKB4ICBAoCCAESBQoDX3QxGgeCAgQKAggCKhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIAGAMiAggDCloKWApO+ghLCiKiBR8SASoaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgeCAgQKAggDGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXiABEgAYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
CkQKQgoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgUKA2RmMRgBIgIIAQpECkIKM+oLMBIOCgwKCnRlc3RfdGFibGUaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIgIIARIFCgNkZjIYAiICCAIKRApCCjjyBjUKB4ICBAoCCAESBQoDX3QxGgeCAgQKAggCKhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIAGAMiAggDCloKWApO+ghLCiKiBR8SASoaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgeCAgQKAggDGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXiABEgAYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.cross_join.rsuffix.test
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ res2 = df1.cross_join(df2, rsuffix="_t2").select("*")

## EXPECTED ENCODED AST

CkQKQgoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgUKA2RmMRgBIgIIAQpECkIKM+ILMBIOCgwKCnRlc3RfdGFibGUaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIgIIARIFCgNkZjIYAiICCAIKRApCCjjyBjUKB4ICBAoCCAEaB4ICBAoCCAIiBQoDX3QyKhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIAGAMiAggDCloKWApO+ghLCiKiBR8SASoaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgeCAgQKAggDGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXiABEgAYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
CkQKQgoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgUKA2RmMRgBIgIIAQpECkIKM+oLMBIOCgwKCnRlc3RfdGFibGUaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIgIIARIFCgNkZjIYAiICCAIKRApCCjjyBjUKB4ICBAoCCAEaB4ICBAoCCAIiBQoDX3QyKhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIAGAMiAggDCloKWApO+ghLCiKiBR8SASoaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgeCAgQKAggDGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXiABEgAYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.cross_join.suffix.test
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ res2 = df1.cross_join(df2, lsuffix="_t1", rsuffix="_t2").select("*")

## EXPECTED ENCODED AST

CkQKQgoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgUKA2RmMRgBIgIIAQpECkIKM+ILMBIOCgwKCnRlc3RfdGFibGUaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIgIIARIFCgNkZjIYAiICCAIKSwpJCj/yBjwKB4ICBAoCCAESBQoDX3QxGgeCAgQKAggCIgUKA190MioaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4SABgDIgIIAwpaClgKTvoISwoiogUfEgEqGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIHggIECgIIAxoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4gARIAGAQiAggEEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
CkQKQgoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgUKA2RmMRgBIgIIAQpECkIKM+oLMBIOCgwKCnRlc3RfdGFibGUaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIgIIARIFCgNkZjIYAiICCAIKSwpJCj/yBjwKB4ICBAoCCAESBQoDX3QxGgeCAgQKAggCIgUKA190MioaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4SABgDIgIIAwpaClgKTvoISwoiogUfEgEqGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIHggIECgIIAxoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4gARIAGAQiAggEEAEaERIPCg0KBWZpbmFsEAMYCSAUIgQQARgX
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.describe.test
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ df3 = df.describe("STR", "num")

## EXPECTED ENCODED AST

CkMKQQoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCj0KOwosggcpCgIQARIHggIECgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSBQoDZGYxGAIiAggCCmMKYQpSggdPCigKJLIMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4SA251bRABEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIFCgNkZjIYAyICCAMKigEKhwEKeIIHdQpOCiSyDCEKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShgEgNTVFIKJLIMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASA251bRABEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIFCgNkZjMYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
CkMKQQoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCj0KOwosggcpCgIQARIHggIECgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSBQoDZGYxGAIiAggCCmMKYQpSggdPCigKJLoMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKF4SA251bRABEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIFCgNkZjIYAyICCAMKigEKhwEKeIIHdQpOCiS6DCEKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShgEgNTVFIKJLoMIQoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGASA251bRABEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIFCgNkZjMYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.flatten.test
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ df2 = df.flatten(col("NUM"), None, False, True, "ARRAY")

## EXPECTED ENCODED AST

CkMKQQoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCm0KawpcugdZCgeCAgQKAggBEiSyDCEKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEgNTVFIaAhABIAEqBgoEcGF0aDoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSBQoDZGYxGAIiAggCCpUBCpIBCoIBugd/CgeCAgQKAggBElKKAU8KCxoJCgcKBQoDY29sGiSyDCEKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgNOVU0iGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheGgIIATABOhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIFCgNkZjIYAyICCAMQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
CkMKQQoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCm0KawpcugdZCgeCAgQKAggBEiS6DCEKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcEgNTVFIaAhABIAEqBgoEcGF0aDoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSBQoDZGYxGAIiAggCCpUBCpIBCoIBugd/CgeCAgQKAggBElKKAU8KCxoJCgcKBQoDY29sGiS6DCEKGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgNOVU0iGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheGgIIATABOhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXhIFCgNkZjIYAyICCAMQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
2 changes: 1 addition & 1 deletion tests/ast/data/DataFrame.indexers.test
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ col = df.select(df["STR"])

## EXPECTED ENCODED AST

CkMKQQoz4gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCm4KbApZ+ghWCi3CBioKA1NUUhIHggIECgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSB4ICBAoCCAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIAESCQoHZ2V0aXRlbRgCIgIIAgpuCmwKWfoIVgotwgYqCgNTVFISB4ICBAoCCAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXiABEgkKB2dldGF0dHIYAyICCAMKagpoCln6CFYKLcIGKgoDU1RSEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIHggIECgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGAgARIFCgNjb2wYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
CkMKQQoz6gswEg4KDAoKdGVzdF90YWJsZRoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFoiAggBEgQKAmRmGAEiAggBCm4KbApZ+ghWCi3CBioKA1NUUhIHggIECgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKFwSB4ICBAoCCAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERShcIAESCQoHZ2V0aXRlbRgCIgIIAgpuCmwKWfoIVgotwgYqCgNTVFISB4ICBAoCCAEaGhoWU1JDX1BPU0lUSU9OX1RFU1RfTU9ERSheEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoXiABEgkKB2dldGF0dHIYAyICCAMKagpoCln6CFYKLcIGKgoDU1RSEgeCAgQKAggBGhoaFlNSQ19QT1NJVElPTl9URVNUX01PREUoYBIHggIECgIIARoaGhZTUkNfUE9TSVRJT05fVEVTVF9NT0RFKGAgARIFCgNjb2wYBCICCAQQARoREg8KDQoFZmluYWwQAxgJIBQiBBABGBc=
Loading
Loading