Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1231581: Enable local testing mode when running doctests. #2469

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

SNOW-1231581: Enable local testing mode when running doctests. #2469

wants to merge 4 commits into from

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1231581

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    This PR adds the --local_testing_mode flag to doctests. This flag is already available for the regular tests, but did not previously work when running doctests in snowflake.snowpark.functions for example.

It also automatically marks any failures as expected if they are caused by local testing not having implemented a function yet.

@sfc-gh-jrose sfc-gh-jrose added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md local testing Local Testing issues/PRs labels Oct 17, 2024
@sfc-gh-jrose sfc-gh-jrose requested review from sfc-gh-aling and a team October 17, 2024 18:24
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner October 17, 2024 18:24
@sfc-gh-jrose sfc-gh-jrose force-pushed the jrose_snow_1231581_local_testing_doctests branch from b9a8702 to f32fe0b Compare October 17, 2024 20:10
@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

@github-actions GitHub Actions
Copy link

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-smirzaei sfc-gh-smirzaei Awaiting requested review from sfc-gh-smirzaei sfc-gh-smirzaei is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
local testing Local Testing issues/PRs NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-jrose @sfc-gh-aling @sfc-gh-aalam