Updates related to SNOW-616002 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to wait to merge this until the change is released in the Python Connector |
sfc-gh-aling
reviewed
Aug 2, 2022
sfc-gh-aling
reviewed
Aug 2, 2022
sfc-gh-aling
reviewed
Aug 2, 2022
|
This would have to wait until the stored proc connector was also updated. @iamontheinet: Could you port your connector changes to https://github.com/snowflakedb/Stored-Proc-Python-Connector ? Or I could do that as part of porting snowflakedb/snowflake-connector-python#1216. |
|
Change itself looks good :) |
sfc-gh-jdu
approved these changes
Aug 5, 2022
|
@iamontheinet I just ran all tests for you and there is still one failure. Could you take a look? |
Fixed :) |
sfc-gh-mabrennan
approved these changes
Aug 8, 2022
sfc-gh-jdu
reviewed
Aug 8, 2022
sfc-gh-aling
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-616002: Ability to overwrite tables when using write_pandas() #383
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Using the write_pandas() API there is now a way to optionally overwrite contents of a Snowflake table with that of a Pandas DataFrame.