Merge pull request #38 from snowio/attribute-lowercase

Make attribute codes be lowercase
snowio · Oct 21, 2021 · fc19561 · fc19561
2 parents 485bb5f + e518d07
commit fc19561
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/src/AttributeData.php b/src/AttributeData.php
@@ -95,7 +95,7 @@ public function equals($attribute): bool
 
     private function __construct(string $attributeCode, string $frontendInput)
     {
-        $this->attributeCode = $attributeCode;
+        $this->attributeCode = strtolower($attributeCode);
         $this->frontendInput = $frontendInput;
     }
 }
diff --git a/src/AttributeSet/AttributeData.php b/src/AttributeSet/AttributeData.php
@@ -9,7 +9,7 @@ final class AttributeData implements ValueObject
     public static function of(string $code): self
     {
         $attributeData = new self;
-        $attributeData->code = $code;
+        $attributeData->code = strtolower($code);
         return $attributeData;
     }
 

diff --git a/test/unit/AttributeDataTest.php b/test/unit/AttributeDataTest.php
@@ -21,6 +21,15 @@ public function testToJson()
             'default_frontend_label' => 'Diameter',
             'scope' => AttributeScope::GLOBAL,
         ], $attribute->toJson());
+
+        $attribute = AttributeData::of('Diameter', FrontendInput::TEXT, 'Diameter');
+        self::assertEquals([
+            'attribute_code' => 'diameter',
+            'is_required' => false,
+            'frontend_input' => 'text',
+            'default_frontend_label' => 'Diameter',
+            'scope' => AttributeScope::GLOBAL,
+        ], $attribute->toJson());
     }
 
     public function testWithers()

diff --git a/test/unit/AttributeSet/AttributeGroupTest.php b/test/unit/AttributeSet/AttributeGroupTest.php
@@ -30,7 +30,7 @@ public function testWithers()
             ->withAttributes(AttributeDataSet::of([
                 AttributeData::of('size')->withSortOrder(1),
                 AttributeData::of('color')->withSortOrder(3),
-                AttributeData::of('density')->withSortOrder(1),
+                AttributeData::of('Density')->withSortOrder(1),
             ]))->withAttribute(AttributeData::of('volume')->withSortOrder(19));
 
         self::assertTrue(AttributeDataSet::of([