Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smallint used as auto increment on snowio_order_relateddata table #14

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Fix smallint used as auto increment on snowio_order_relateddata table #14

merged 1 commit into from
Sep 7, 2020

Conversation

tr33m4n
Copy link
Contributor

@tr33m4n tr33m4n commented Sep 7, 2020

Description

The id field for the snowio_order_relateddata has been set to a smallint. This means that its maximum auto increment size is 32767 which is easily depleted. This PR updates the column to int(10) unsigned which has a maximum size of 4294967295

@tr33m4n tr33m4n self-assigned this Sep 7, 2020
alexanderwanyoike
alexanderwanyoike approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@alexanderwanyoike alexanderwanyoike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tr33m4n tr33m4n merged commit e4c53e2 into snowio:master Sep 7, 2020
@tr33m4n tr33m4n deleted the fix/smallint-autoincrement branch September 7, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderwanyoike alexanderwanyoike alexanderwanyoike approved these changes

@thisisandrew thisisandrew thisisandrew approved these changes

Assignees

@tr33m4n tr33m4n

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tr33m4n @thisisandrew @alexanderwanyoike