-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Acyclic.AdjacencyMap #223
Conversation
I apologize, I believe I should have done these properly. Please let me know during the PR review whether the format of the tests is proper, I'll change them accordingly. |
No need to apologise! It's much easier to do a revision than to start from scratch :) Thanks again for your earlier work, and I hope you agree with my changes. If not, please let me know! |
@adithyaov I think I'm finished with this revision. I didn't implement the |
@adithyaov I'd appreciate if you have a quick look at my changes. I'd like to merge as soon as possible to avoid blocking other PRs. |
@snowleopard I went over most of the files, it looks good to me. I did not cross-check the changes in the run time complexity yet. I'll go through this PR more thoroughly and get back to you by tomorrow. |
@adithyaov Thank you! I'll wait with merging until tomorrow.
I think I only fixed an error that I had in the documentation of |
@snowleopard I went through all the files. There seems to be a little inconsistency in the examples of Other than that everything seems to be fine. |
@adithyaov Many thanks for having a look! I've fixed the inconsistency you found. |
This PR includes:
disjointOverlay
tounion
anddisjointConnect
tojoin
, which are commonly used terms.isSubgraphOf
,preSet
,postSet
.PartialOrder
: I'm still hesitating about providing an unsafe construction method.Acyclic.Ord
toAcyclic.AdjacencyMap.Ord
, and removing some functions from the API.