Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/snowplow-web/0.5.0 #53

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Release/snowplow-web/0.5.0 #53

merged 3 commits into from
Dec 17, 2021

Conversation

bill-warner
Copy link
Contributor

Running through Redshift tests. Will confirm results

Copy link

@paulboocock paulboocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming your Redshift tests went ok and the temp commit is removed 👍

@bill-warner bill-warner force-pushed the release/snowplow-web/0.5.0 branch 2 times, most recently from 2c2f39a to fadda79 Compare December 16, 2021 14:32
@bill-warner
Copy link
Contributor Author

For clarity I am holding off merging this as although all tests pass on Redshift, dbt is throwing warnings for the optional page view context models such as:

[WARNING]: Test 'test.snowplow_web.not_null_snowplow_web_pv_iab_page_view_id.858bd03daa' (models/page_views/scratch/page_views_scratch.yml) depends on a node named 'snowplow_web_pv_iab' which is disabled

This is because the model snowplow_web_pv_iab is disabled by default using the snowplow__enable_iab var but the tests are not.

These page view context models are only to be run on Redshift and Postgres and as such I have set the tests to only run for these databases:

- unique:
enabled: "{{ target.type in ['redshift', 'postgres'] | as_bool() }}"
- not_null:
enabled: "{{ target.type in ['redshift', 'postgres'] | as_bool() }}"

I have tried disabling the test if the model is also disabled like beneath but unfortunately the vars value doesnt seem to be being read in from the dbt_project.yml file where it is set.

- unique:
     enabled: "{{ var('snowplow__enable_iab') and target.type in ['redshift', 'postgres'] | as_bool() }}"

I have reached out to dbt for help

@bill-warner
Copy link
Contributor Author

I think the issue I outlined above has been raised already:
dbt-labs/dbt-core#3698

Added my example in the hope of speeding up the fix. I think I have a workaround - will add now.

@bill-warner
Copy link
Contributor Author

All tests for Redshift have passed locally. @paulboocock - will fix up latest commit and merge PR once you have cast your eye over the fix.

Copy link

@paulboocock paulboocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a fun little bug. The fix looks good to me though.

@bill-warner bill-warner force-pushed the release/snowplow-web/0.5.0 branch from 5c32d56 to 4305dfe Compare December 17, 2021 10:14
@bill-warner bill-warner merged commit c0adfb1 into main Dec 17, 2021
@emielver emielver deleted the release/snowplow-web/0.5.0 branch March 11, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants