Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shouldStripHeaderOnRedirect to Request #386

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Add shouldStripHeaderOnRedirect to Request #386

merged 1 commit into from
Feb 27, 2019

Conversation

dzhus
Copy link
Contributor

@dzhus dzhus commented Feb 25, 2019

As discussed in #300 (comment)

We don't change the current behaviour hence no major bump

@snoyberg
Copy link
Owner

Looks like the builds are failing:

    /Users/travis/build/snoyberg/http-client/http-conduit/Network/HTTP/Simple.hs:356:25: error:
        • Variable not in scope: (<>) :: H.Query -> H.Query -> t
        • Perhaps you meant one of these:
            ‘<$>’ (imported from Prelude), ‘*>’ (imported from Prelude),
            ‘<$’ (imported from Prelude)
        |
    356 |     where q = additions <> getRequestQueryString req

@dzhus
Copy link
Contributor Author

dzhus commented Feb 26, 2019

It's unrelated – master is broken too (see #387, then I'll rebase)

@dzhus
Copy link
Contributor Author

dzhus commented Feb 27, 2019

@snoyberg All green now

Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! And thank you doubly for fixing CI!

@snoyberg snoyberg merged commit 5f633d8 into snoyberg:master Feb 27, 2019
@snoyberg snoyberg mentioned this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants