Skip to content

Commit

Permalink
Merge pull request #5510 from snyk/chore/remove-use-of-eol-node
Browse files Browse the repository at this point in the history
chore(ci): remove use of EOL node
  • Loading branch information
thisislawatts authored Sep 28, 2024
2 parents c24eecb + f873382 commit 6976a36
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/smoke-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ jobs:
matrix:
os: [ubuntu, macos, windows]
snyk_install_method: [binary, npm, yarn, brew]
node_version: [16, 18, 20]
node_version: [18, 20]
exclude:
# Skip yarn for Windows, as it's a bit crazy to get it working in CI environment. Unless we see evidence we need it, I'd avoid it
- snyk_install_method: yarn
os: windows
# For binary, use only the Node 18
- snyk_install_method: binary
node_version: 16
node_version: 18
# No need to run brew tests on some Platforms
- snyk_install_method: brew
os: ubuntu
Expand All @@ -40,14 +40,14 @@ jobs:
snyk_cli_dl_file: snyk-macos
- snyk_install_method: alpine-binary
os: ubuntu
node_version: 16
node_version: 18
snyk_cli_dl_file: snyk-alpine
- snyk_install_method: npm-root-user
os: ubuntu
node_version: 16
node_version: 18
- snyk_install_method: docker-bundle
os: macos
node_version: 16
node_version: 18
snyk_cli_dl_file: snyk-for-docker-desktop-darwin-x64.tar.gz

steps:
Expand Down
2 changes: 1 addition & 1 deletion test/smoke/alpine/entrypoint.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh

curl -Lo ./snyk-cli 'https://static.snyk.io/cli/latest/snyk-alpine'
curl -Lo ./snyk-cli 'https://downloads.snyk.io/cli/latest/snyk-alpine'
chmod -R +x ./snyk-cli
mv ./snyk-cli /usr/local/bin/snyk
snyk --version
Expand Down
2 changes: 1 addition & 1 deletion test/smoke/install-snyk-binary-win.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
curl -Lo ./snyk-cli.exe 'https://static.snyk.io/cli/latest/snyk-win.exe'
curl -Lo ./snyk-cli.exe 'https://downloads.snyk.io/cli/latest/snyk-win.exe'
./snyk-cli.exe --version
chmod -R +x ./snyk-cli
mv ./snyk-cli.exe "/bin/snyk.exe"
Expand Down

0 comments on commit 6976a36

Please sign in to comment.