Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: determine correct LockfileType for yarn v2 #1336

Closed
wants to merge 1 commit into from
Closed

fix: determine correct LockfileType for yarn v2 #1336

wants to merge 1 commit into from

Conversation

mhassan1
Copy link
Contributor

@mhassan1 mhassan1 commented Aug 14, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Adds support for Yarn v2 with the --yarn-workspaces flag

Where should the reviewer start?

package.json

How should this be manually tested?

snyk test --yarn-workspaces in a Yarn v2 package that contains Yarn Workspaces

What are the relevant tickets?

https://github.com/snyk/snyk/issues/1322

@mhassan1 mhassan1 requested review from a team as code owners August 14, 2020 18:18
@ghost ghost requested review from anthogez and orsagie August 14, 2020 18:18
@orsagie
Copy link
Contributor

orsagie commented Aug 18, 2020

Hey @mhassan1 thanks for your contribution! We actually already have detection for yarn v2 in our parser, but you pointed out that we were not doing it in both buildDepTree methods. I added this detection in the parser, so that we don't need this extra check in the Snyk CLI : snyk/nodejs-lockfile-parser#84.
Once the above is merged in, let's change this PR to update the dependency of snyk-nodejs-lockfile-parser, and keep the test you added :)

Copy link
Contributor

@orsagie orsagie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big 👍

@orsagie
Copy link
Contributor

orsagie commented Aug 20, 2020

closing and reopening to trigger test

@orsagie orsagie closed this Aug 20, 2020
@orsagie orsagie reopened this Aug 20, 2020
@orsagie
Copy link
Contributor

orsagie commented Aug 20, 2020

@mhassan1 I need to create a separate branch to trigger the tests. Can you send me your email so I can add you as contributor? to or@snyk.io

@lili2311
Copy link
Contributor

@orsagie I raised a PR and cherry-picked the commit :) Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants