-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move constants for test-unpublished to json and add it to packag… #230
Conversation
2a7338e
to
242a7c9
Compare
Looking good, just playing around with it locally. |
.split('\n').map(function (s) { | ||
return s.trim(); | ||
}); | ||
var config = JSON.parse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move away form using var
now, perhaps lets update this to const
var tail = fs.readFileSync(__dirname + '/tail.txt', 'utf8'); | ||
var lbl = fs.readFileSync(__dirname + '/head.txt', 'utf8'); | ||
var packages = config.packages; | ||
var tail = config.tail; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can update this to be const { packages, tail, head:lbl } = config;
since we can now play around with newer syntax
b592f2c
to
18c5fbf
Compare
f42a1d8
to
53f1c49
Compare
@lili2311 fixed. |
🎉 This PR is included in version 1.100.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…e #225
Any background context you want to provide?
Constants for test-unpublished command was in txt file and wasn't included to the npm package.
What are the relevant tickets?
https://github.com/snyk/snyk/issues/225
#226