Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propertly create target file path for --file= with absolute path #2319

Merged
merged 1 commit into from
Oct 25, 2021
Merged

fix: propertly create target file path for --file= with absolute path #2319

merged 1 commit into from
Oct 25, 2021

Conversation

maxjeffos
Copy link
Contributor

What does this PR do?

Uses .resolve rather than .join to compute the target file path when using --file=<absolute-path. This fixes the resolution of the .snyk file in these scenarios.

ZD 10425

@maxjeffos maxjeffos requested review from a team as code owners October 22, 2021 18:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2021 •
edited
Loading

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/snyk-test/run-test.ts

Generated by 🚫 dangerJS against 8f4f9c7

@maxjeffos maxjeffos force-pushed the fix/load-policy-file-with-file-equals-and-absolute-path branch from 5f623da to 5cba009 Compare October 23, 2021 14:43
@maxjeffos maxjeffos force-pushed the fix/load-policy-file-with-file-equals-and-absolute-path branch from 5cba009 to 8f4f9c7 Compare October 23, 2021 15:51
@maxjeffos maxjeffos merged commit 6014584 into master Oct 25, 2021
@maxjeffos maxjeffos deleted the fix/load-policy-file-with-file-equals-and-absolute-path branch October 25, 2021 13:30
@snyk-bot snyk-bot mentioned this pull request Jan 13, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avishagp Avishagp Avishagp approved these changes

@jan-stehlik jan-stehlik Awaiting requested review from jan-stehlik jan-stehlik was automatically assigned from snyk/loki

@tonidevine1 tonidevine1 Awaiting requested review from tonidevine1 tonidevine1 was automatically assigned from snyk/loki

@gitphill gitphill Awaiting requested review from gitphill gitphill was automatically assigned from snyk/tardis

@dtrunley-snyk dtrunley-snyk Awaiting requested review from dtrunley-snyk dtrunley-snyk was automatically assigned from snyk/tardis

@alexandruz alexandruz Awaiting requested review from alexandruz alexandruz was automatically assigned from snyk/tundra

@cristian-pana cristian-pana Awaiting requested review from cristian-pana cristian-pana was automatically assigned from snyk/tundra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxjeffos @Avishagp