Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve output for dockerfile instructions #2353

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

pecodez
Copy link
Contributor

@pecodez pecodez commented Nov 10, 2021

What does this PR do?

This PR allows for use of the installCommand, extracted from a RUN instruction in newer versions of the SDP, to provide a better output for dockerFile user instructions.

https://snyksec.atlassian.net/browse/CAP-280

@pecodez pecodez self-assigned this Nov 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2021

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/snyk-test/run-test.ts
  • test/acceptance/cli-test/cli-test.docker.spec.ts

Generated by 🚫 dangerJS against 4690660

@pecodez pecodez force-pushed the feat/CAP-280-improve-user-instruction-info branch from 166c31a to 0aaaf72 Compare November 19, 2021 10:52
@agatakrajewska
Copy link
Contributor

I think we actually could release the SDP first, and add that bump here, so we only raise the cli PR once

@pecodez pecodez marked this pull request as ready for review November 22, 2021 15:55
@pecodez pecodez requested review from a team as code owners November 22, 2021 15:55
@pecodez pecodez force-pushed the feat/CAP-280-improve-user-instruction-info branch from a6cde6d to ca2c254 Compare November 22, 2021 17:41
@pecodez pecodez force-pushed the feat/CAP-280-improve-user-instruction-info branch 2 times, most recently from 1c0d90c to 06bd47c Compare November 23, 2021 16:08
@pecodez pecodez requested a review from a user November 23, 2021 16:44
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd suggest find/replacing all usages of "instruction" in this context to "install command" in test names, variable names, etc. It's confusing/inconsistent otherwise.

src/lib/snyk-test/run-test.ts Show resolved Hide resolved
This commit allows for use of the installCommand extracted
from a RUN instruction in newer versions of the SDP.

[CAP-280]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants