Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): run windows tests against snyk-win.exe #2666

Merged
1 commit merged into from
Feb 7, 2022
Merged

chore(ci): run windows tests against snyk-win.exe #2666

1 commit merged into from
Feb 7, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2022 •
edited by ghost
Loading

This ensures our Windows builds are valid before release.

I've removed npm_version from analytics as it's only relevant for OSS NPM scans rather than being "standard data".

Also made general analytics test changes so that they're more flexible to different test environments.

@ghost ghost deleted a comment Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022 •
edited
Loading

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/analytics/getStandardData.ts
Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 6012e60

@ghost ghost force-pushed the chore/test-win-exe branch 9 times, most recently from e37c14e to 6012e60 Compare January 31, 2022 19:44
@ghost ghost marked this pull request as ready for review January 31, 2022 20:11
@ghost ghost requested review from a team as code owners January 31, 2022 20:11
karniwl
karniwl approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@karniwl karniwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌

@ghost ghost changed the base branch from master to chore/merge-pipelines February 7, 2022 12:42
@ghost ghost force-pushed the chore/test-win-exe branch from 6012e60 to 38db9f0 Compare February 7, 2022 12:46
chore(ci): run windows tests against snyk-win.exe
b6b1686 
This ensures our Windows builds are valid before release.

I've removed `npm_version` from analytics as it's only relevant for
OSS NPM scans rather than being "standard data".

Also made general analytics test changes so that they're more flexible
to different test environments.
@ghost ghost force-pushed the chore/test-win-exe branch from 38db9f0 to b6b1686 Compare February 7, 2022 12:47
Base automatically changed from chore/merge-pipelines to master February 7, 2022 15:08
@ghost ghost merged commit 0a1e56a into master Feb 7, 2022
@ghost ghost deleted the chore/test-win-exe branch February 7, 2022 16:02
@florinMiro florinMiro mentioned this pull request Jan 20, 2023
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 1, 2023
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitphill gitphill Awaiting requested review from gitphill gitphill was automatically assigned from snyk/snyk-open-source

@danlucian danlucian Awaiting requested review from danlucian danlucian was automatically assigned from snyk/snyk-open-source

@magdziarek magdziarek Awaiting requested review from magdziarek magdziarek was automatically assigned from snyk/snyk-open-source

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karniwl @maxjeffos