Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unmanaged cancelled jobs #3254

Merged
merged 1 commit into from
May 20, 2022
Merged

fix: unmanaged cancelled jobs #3254

merged 1 commit into from
May 20, 2022

Conversation

danlucian
Copy link
Member

@danlucian danlucian commented May 19, 2022 •
edited
Loading

What does this PR do?

  • throw an error when the unmanaged c++ jobs are cancelled or contain error

@danlucian danlucian self-assigned this May 19, 2022
@danlucian danlucian requested review from a team as code owners May 19, 2022 19:23
dekelund
dekelund approved these changes May 20, 2022
View reviewed changes
Copy link

@dekelund dekelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but it doesn't block the PR itself.

ghost
ghost suggested changes May 20, 2022
View reviewed changes
src/lib/polling/polling-test.ts Outdated Show resolved Hide resolved
ghost
ghost approved these changes May 20, 2022
View reviewed changes
src/lib/polling/polling-test.ts Outdated Show resolved Hide resolved
@danlucian
fix: unmanaged cancelled jobs
dca7769 
- throw an error when the unmanaged c++ jobs are cancelled or contain error
- add tests
@danlucian danlucian force-pushed the fix/unmanaged-cancelled-jobs branch from c093288 to dca7769 Compare May 20, 2022 10:55
@danlucian danlucian merged commit e082575 into master May 20, 2022
@danlucian danlucian deleted the fix/unmanaged-cancelled-jobs branch May 20, 2022 11:40
@aliscco aliscco mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekelund dekelund dekelund approved these changes

@jonathansantilli jonathansantilli Awaiting requested review from jonathansantilli jonathansantilli was automatically assigned from snyk/snyk-open-source

@robcresswell robcresswell Awaiting requested review from robcresswell robcresswell was automatically assigned from snyk/snyk-open-source

@robh-snyk robh-snyk Awaiting requested review from robh-snyk robh-snyk was automatically assigned from snyk/snyk-open-source

Assignees

@danlucian danlucian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danlucian @dekelund