Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile for scanning Docker repos #333

Closed
wants to merge 1 commit into from

Conversation

lfdebrux
Copy link

@lfdebrux lfdebrux commented Jan 15, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add a Dockerfile for generating a Docker image with the Snyk CLI and the Docker CLI.

This means that a Docker user can scan Docker images using a Docker image!

Where should the reviewer start?

Build with

docker build -t snyk/snyk-cli:docker -f docker/Dockerfile.docker docker

How should this be manually tested?

Run using a command such as

docker run --rm \
    -e SNYK_TOKEN=$SNYK_TOKEN \
    -v $(pwd):/project \
    -v /var/run/docker.sock:/var/run/docker.sock \
    snyk/snyk-cli:docker \
    test --docker snyk/snyk-cli:docker --file=docker/Dockerfile.docker --json

Any background context you want to provide?

I want to run Snyk tests on Docker images generated on CI, and it's easier to have Snyk in a container than install it on the CI server.

Additional questions

Can this also be added to the build system with the other Docker images?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants