Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore snyk report and result files #336

Closed
wants to merge 1 commit into from
Closed

chore: Ignore snyk report and result files #336

wants to merge 1 commit into from

Conversation

prehor
Copy link
Contributor

@prehor prehor commented Jan 20, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Git should ignore snyk report and result files.

@FauxFaux FauxFaux requested a review from a team November 29, 2019 15:13
@ghost ghost requested review from miiila and orsagie November 29, 2019 15:13
@lili2311
Copy link
Contributor

lili2311 commented Jan 7, 2020

👋 Hi, just wondering why is this desirable in this repo?

@prehor
Copy link
Contributor Author

prehor commented Jan 7, 2020

Hi @lili2311, if you try to eat your own dog food (for example, test what Snyk thinks about your own Docker images like I tried), someone might accidentally commit Snyk reports.

@lili2311
Copy link
Contributor

lili2311 commented Jan 7, 2020

Pulled in the commit here to get the tests running & passing #946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants