fix: --target-name bug
#3618
Merged
fix: --target-name bug
#3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YairZ101
force-pushed
the
fix/target-name
branch
from
7f4ee14
to
333cab4
Compare
YairZ101
commented
Aug 24, 2022
| @@ -20,7 +20,7 @@ export interface ContainerTarget { | |||
| image: string; | |||
| } | |||
|
|
|||
| export interface UnknownTarget { | |||
| export interface NamedTarget extends GitTarget { | |||
There was a problem hiding this comment.
I'm not 100% sure if this is the best approach here, maybe adding name as an optional field to GitTarget is a better option?
YairZ101
force-pushed
the
fix/target-name
branch
2 times, most recently
from
127e9f0
to
090d2dd
Compare
YairZ101
requested review from
karniwl,
robcresswell,
Jdunsby,
robh-snyk,
ofekatr and
francescomari
and removed request for
karniwl and
ofekatr
YairZ101
force-pushed
the
fix/target-name
branch
from
090d2dd
to
a025187
Compare
YairZ101
force-pushed
the
fix/target-name
branch
from
a025187
to
3431f79
Compare
francescomari
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
IaC has recently introduced a new flag in the CLI called
--target-namethat as the name suggest allows the user to overwrite the target name in the platform.We currently have a bug where when scanning a directory that is a root of a repo the target name is not getting overridden with the one that the user set by using the flag.
This PR adds the ability to add the name field to the target together with git information, in registry we can use the
nameto overwrite thetargetname.How should this be manually tested?
snyk-dev iac test --report --target-name=testAny background context you want to provide?
The fix in this PR is dependent on the fix in https://github.com/snyk/registry/pull/28707.
What are the relevant tickets?
https://snyksec.atlassian.net/jira/software/c/projects/CFG/boards/301?modal=detail&selectedIssue=CFG-2101