chore: Add issue remediation to test output [CFG-2124] #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekatr
force-pushed
the
chore/add-issue-remediation-cfg-2124
branch
3 times, most recently
from
9cef9aa
to
2cd99d7
Compare
ipapast
reviewed
Sep 2, 2022
ofekatr
force-pushed
the
chore/add-issue-remediation-cfg-2124
branch
from
2cd99d7
to
3fa6b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
policy-enginefor any issues in the test output in all relevant output formats:How should this be manually tested?
snyk iac test --experimentaland ensure any displayed issues include the expected one-liner remediation advice.snyk iac test --experimental --jsonand ensure any displayed issues include the expected one-liner remediation advice.snyk iac test --experimental --sarifand ensure any displayed issues include the expected one-liner remediation advice.Any background context you want to provide?
A proposal was approved to keep the one-liner format for security rules. In the new format, the remediation property is a dictionary that maps project types to their respective remediation advice. In each remediation advice, the first paragraph is a one-liner version that summarizes the recommended actions. The changes were applied (PR) and are available through policy-engine.
What are the relevant tickets?