Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Added short-width terminals support for text output [cfg-2072] #3821

Merged
merged 1 commit into from
Sep 7, 2022
Merged

chore: Added short-width terminals support for text output [cfg-2072] #3821

merged 1 commit into from
Sep 7, 2022

Conversation

ofekatr
Copy link
Contributor

@ofekatr ofekatr commented Sep 5, 2022 •
edited
Loading

What does this PR do?

  • Ensures readability for terminals with a width lower than the default 80 columns.

Where should the reviewer start?

src/lib/formatters/iac-output/text/utils.ts

How should this be manually tested?

  • Narrow your CLI to a width lower than 80 columns.
  • Run snyk iac test to test files.
  • Ensures the issue descriptions remain readable and that the indentation acts as expected.

Screenshots

image

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022 •
edited
Loading

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against a0f7595

@ofekatr ofekatr marked this pull request as ready for review September 5, 2022 14:29
@ofekatr ofekatr requested a review from a team as a code owner September 5, 2022 14:29
@ofekatr ofekatr force-pushed the chore/add-short-width-support branch from a216662 to a0f7595 Compare September 5, 2022 14:35
@ofekatr ofekatr removed the request for review from francescomari September 7, 2022 11:24
@ofekatr ofekatr merged commit 29efc04 into master Sep 7, 2022
@ofekatr ofekatr deleted the chore/add-short-width-support branch September 7, 2022 11:26
@ipapast ipapast changed the title chore: Added short-width terminals support for text output chore: Added short-width terminals support for text output [cfg-2072] Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YairZ101 YairZ101 YairZ101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofekatr @YairZ101