[CTX-403] feat: IaC context-suppressed issue count #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfurman
force-pushed
the
feat/iac-suppressed-issue-count
branch
2 times, most recently
from
523fed4
to
9a3a65b
Compare
When snyk-iac-test returns suppressedResults in scan analytics, display a total count of suppressed issues alongside the other scan counts.
craigfurman
force-pushed
the
feat/iac-suppressed-issue-count
branch
from
9a3a65b
to
bb18d47
Compare
moadibfr
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When snyk-iac-test returns suppressedResults in scan analytics, display a total count of suppressed issues alongside the other scan counts.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
This feature
iac test --cloud-context=...is still undocumented and is only available behind a feature flag. The context-suppressed count will only appear when any issues are actually suppressed, which should not actually occur for non-snyk-developer users yet.This PR depends on the PR'ed
+ unmergedscanAnalytics field in snyk-iac-test's return payload. If approved, this PR should be updated with the new pinned version that is released after https://github.com/snyk/snyk-iac-test/pull/115 is merged, before merging this one.What are the relevant tickets?
https://snyksec.atlassian.net/browse/CTX-403
Screenshots
When cloud-context has found issues:
Note that this field does not appear when
--cloud-contextis not requested:Additional questions