Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unmanaged scan unknown archives #3851

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

gitphill
Copy link
Contributor

@gitphill gitphill commented Sep 15, 2022

What does this PR do?

See snyk/snyk-mvn-plugin#137

Adding warning message to indicate when projects have a dep-graph that contains packages with unknown versions (like in the Snyk UI).

Screenshots

Screenshot 2022-09-28 at 14 53 32

@gitphill gitphill requested review from a team as code owners September 15, 2022 15:17
@gitphill gitphill self-assigned this Sep 15, 2022
@gitphill gitphill force-pushed the fix/unmanaged-scan-unknown-archives branch 2 times, most recently from e182898 to d8b9aae Compare September 28, 2022 12:46
Copy link
Contributor

@JackuB JackuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the hammer owned files. But left a suggestion

src/lib/formatters/test/display-result.ts Outdated Show resolved Hide resolved
@gitphill gitphill force-pushed the fix/unmanaged-scan-unknown-archives branch from d8b9aae to b0cfd98 Compare September 28, 2022 13:54
See snyk/snyk-mvn-plugin#137

Adding warning message to indicate when projects have a dep-graph that contains packages with unknown versions (like in the Snyk UI).
@gitphill gitphill force-pushed the fix/unmanaged-scan-unknown-archives branch from b0cfd98 to 5821ed4 Compare September 29, 2022 08:17
@gitphill gitphill merged commit 1bbba78 into master Sep 29, 2022
@gitphill gitphill deleted the fix/unmanaged-scan-unknown-archives branch September 29, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants