Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: OS CLI output update #4210

Closed
wants to merge 2 commits into from
Closed

Conversation

dagrest
Copy link

@dagrest dagrest commented Nov 17, 2022

What does this PR do?

  • add description labels
  • add issue summary
  • actionable focus on upgrade
  • count issues
  • newline separates issues
  • update severity headline

This PR is based on the following PRs:
feat:OS CLI output part I - update severity headline +test
feat:OS CLI output part II - newline separates issues +test
feat:OS CLI output part III - count issues +test
feat:OS CLI output part IV - actionable focus on upgrade
feat:OS CLI output part V - add issue summary
feat:OS CLI output part VI - add description labels

Where should the reviewer start?

src/lib/formatters/remediation-based-format-issues.ts
src/lib/formatters/format-test-meta.ts
src/lib/formatters/types.ts

How should this be manually tested?

Run 'snyk test' and 'snyk test --unmanaged' commands on a local project and compare output formatting with the attached screenshot

Any background context you want to provide?

What are the relevant tickets?

What are the relevant tickets?
TUN-269

Screenshots

Additional questions

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/unit/lib/formatters/remediation-based-format-issues.spec.ts

Generated by 🚫 dangerJS against 93c84bd

@dagrest dagrest force-pushed the feat/os-cli-output-update-new branch from f9d428c to dc83500 Compare November 17, 2022 09:27
@dekelund dekelund self-requested a review November 17, 2022 09:57
dekelund
dekelund previously approved these changes Nov 17, 2022
@dagrest dagrest force-pushed the feat/os-cli-output-update-new branch 6 times, most recently from ebdaba7 to e501c56 Compare November 20, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants