Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context flag to Snyk App create command #4449

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

jgresty
Copy link
Member

@jgresty jgresty commented Mar 3, 2023

What does this PR do?

Add a new flag --context to the Snyk Apps create command.

Where should the reviewer start?

How should this be manually tested?

Run apps create, both with and without --interactive is supported.

Any background context you want to provide?

The context flag is just passed to the create app endpoint, at this time we accept 'tenant' (the old option) and 'user'. This is to support Snyk Apps that act on behalf of users rather than utilising a bot user.

What are the relevant tickets?

Screenshots

Additional questions

@jgresty jgresty requested review from a team as code owners March 3, 2023 11:12
@jgresty jgresty force-pushed the feat/add-context-to-app-create branch from 0e00ddd to 7ab8fe3 Compare March 3, 2023 12:54
Copy link
Contributor

@michelkaporin michelkaporin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jgresty jgresty force-pushed the feat/add-context-to-app-create branch from 7ab8fe3 to 6cad5e1 Compare March 3, 2023 15:24
The context flag is just passed to the create app endpoint, at this time
we accept 'tenant' (the old option) and 'user'. This is to support Snyk
Apps that act on behalf of users rather than utilising a bot user.
@jgresty jgresty force-pushed the feat/add-context-to-app-create branch from 6cad5e1 to a483033 Compare March 6, 2023 09:51
@jgresty jgresty merged commit ed26e75 into master Mar 6, 2023
@jgresty jgresty deleted the feat/add-context-to-app-create branch March 6, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants