fix: fix project name override with sub projects #4837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When we scan a mono repo where in the root dir there's no project config but only sub dirs containing sub projects, e.g. like following
We noticed that when doing
snyk monitor
instead of creating two projects, it creates onemy-mono-repo
project and the vulnerabilities found in the sub projects are overriding, and theExplore this snapshot at
message printed out locally points to exactly the same remote URL.We found that this issue is caused by that the
project-name
is missing as part of the meta data.This PR supplies that missing
project-name
. The fixing has been tested locally and works well.Screenshots
Before:
After: