Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix wrong project name change #4865

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

xzhou-snyk
Copy link
Contributor

Due to a previous fixing for gradle, we accidentally also changed the name of many existing CLI projects.

That affects ecosystems such as dotnet, cocoapads, golang projects not using go module, swift and composer.

This PR reverts the name change for those projects while still preserving the expected behavior for gradle.

@xzhou-snyk xzhou-snyk requested review from a team as code owners September 19, 2023 16:24
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/commands/monitor/index.ts

Generated by 🚫 dangerJS against 0c87ff8

@xzhou-snyk xzhou-snyk force-pushed the fix/revert-cli-project-name-change branch 2 times, most recently from a3ee766 to 1abbd7e Compare September 19, 2023 17:00
@xzhou-snyk xzhou-snyk force-pushed the fix/revert-cli-project-name-change branch from 1abbd7e to 0c87ff8 Compare September 19, 2023 17:09
@xzhou-snyk xzhou-snyk merged commit f1b634d into master Sep 19, 2023
11 checks passed
@xzhou-snyk xzhou-snyk deleted the fix/revert-cli-project-name-change branch September 19, 2023 18:31
@stevewithey
Copy link

stevewithey commented Sep 20, 2023

When will this change propagate to the Azure DevOps Task? I'm still seeing this issue in scans this morning. We're using MS Hosted Agents with the Snyk scan task.

@stevewithey
Copy link

When will this change propagate to the Azure DevOps Task? I'm still seeing this issue in scans this morning. We're using MS Hosted Agents with the Snyk scan task.

This seems to have resolved now, must have been a caching issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants