Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inject variable/secret TEST_SNYK_TOKEN into workflow step #4898

Merged
merged 4 commits into from
Oct 10, 2023
Merged

fix: inject variable/secret TEST_SNYK_TOKEN into workflow step #4898

merged 4 commits into from
Oct 10, 2023

Conversation

bastiandoetsch
Copy link
Contributor

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@bastiandoetsch bastiandoetsch requested review from a team as code owners October 9, 2023 08:28
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited
Loading

Fails
🚫

"Merge branch 'master' into fix/smoke-tests" is not using a valid commit message format. For commit guidelines, see: CONTRIBUTING.
Messages
📖

You are modifying something in test/smoke directory, yet you are not on the branch starting with smoke/. You can prefix your branch with smoke/ and Smoke tests will trigger for this PR.

Generated by 🚫 dangerJS against 4fb5728

@bastiandoetsch bastiandoetsch reopened this Oct 9, 2023
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) October 9, 2023 13:06
cat2608
cat2608 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@cat2608 cat2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bastiandoetsch bastiandoetsch merged commit dde78c9 into master Oct 10, 2023
8 of 9 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/smoke-tests branch October 10, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cat2608 cat2608 cat2608 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastiandoetsch @cat2608