fix: update snyk-iac-capture now allowing to upload valid empty states #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: Is there a way to add an acceptance test that helps verify against regression in the future? |
|
@PeterSchafer we already have two general acceptance tests for |
PeterSchafer
approved these changes
Oct 12, 2023
|
@PeterSchafer I'm not sure why the two Snyk checks are stuck, is there something you can do from your side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades the version of snyk-iac-capture that we're pulling in. The new version makes sure that we can correctly upload valid, but empty terraform state files (i.e. after running
terraform destroy).Changes between 0.6.0 and 0.6.4 were just around developer experience, CI, etc. (see here).
And the changes in 0.6.5 are here
What are the relevant tickets?
IAC-2652