feat: use depGraph lib for npm and yarn snyk-test path #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyegupov
force-pushed
the
feat/use-dep-graph-for-npm-test
branch
3 times, most recently
from
4ab0014
to
90e979c
Compare
orsagie
reviewed
May 8, 2019
src/lib/snyk-test/nodejs/index.ts
Outdated
| @@ -114,8 +125,7 @@ async function assembleLocalPayload(root: string, options): Promise<Payload> { | |||
| if (policyLocations.length > 0) { | |||
| try { | |||
| policy = await snyk.policy.load(policyLocations, options); | |||
| // TODO(kyegupov): is this logging required? | |||
| console.log('POLICY: ', JSON.stringify({...pkg, policy})); | |||
| // console.log('POLICY: ', JSON.stringify({...pkg, policy})); | |||
There was a problem hiding this comment.
might as well just delete it if you think it's not necessary
orsagie
approved these changes
May 8, 2019
kyegupov
force-pushed
the
feat/use-dep-graph-for-npm-test
branch
2 times, most recently
from
5982e26
to
77f228c
Compare
kyegupov
force-pushed
the
feat/use-dep-graph-for-npm-test
branch
from
77f228c
to
a085a05
Compare
3 tasks
|
🎉 This PR is included in version 1.163.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Effectively the second part of #459 , with updates
What are the relevant tickets?
https://snyksec.atlassian.net/browse/BST-582