refactor: Keep track of supported wizard package managers instead #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
force-pushed
the
refactor/supported-wizard-langs
branch
2 times, most recently
from
caf7675
to
f8d7fea
Compare
lili2311
commented
May 21, 2019
| var unsupportedPackageManagers = { | ||
| rubygems: 'RubyGems', | ||
| maven: 'Maven', | ||
| pip: 'Python', |
There was a problem hiding this comment.
Python is not a package manager, Pip is
kyegupov
approved these changes
May 21, 2019
lili2311
force-pushed
the
refactor/supported-wizard-langs
branch
3 times, most recently
from
074183f
to
44303fc
Compare
lili2311
force-pushed
the
refactor/supported-wizard-langs
branch
from
44303fc
to
2cc3f64
Compare
|
🎉 This PR is included in version 1.165.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keep track of supported package managers rather than unsupported ones for wizard, easier to read and less risk of missing to add one into this array