Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix broken snyk help #566

Merged
merged 1 commit into from
Jun 10, 2019
Merged

fix: fix broken snyk help #566

merged 1 commit into from
Jun 10, 2019

Conversation

kyegupov
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fix snyk help which was broken by #547; add test.

@kyegupov kyegupov requested a review from miiila June 10, 2019 10:17
@kyegupov kyegupov self-assigned this Jun 10, 2019
orsagie
orsagie reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@orsagie orsagie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also return the result of the file read

@miiila
Copy link
Contributor

miiila commented Jun 10, 2019

@orsagie is right, see:

mila@millenniumfalcon ~/dev/snyk/snyk ‹node@v8.12.0› ‹npm@6.9.0› ‹fix/snyk-help›
$ snyk-dev help ignore

mila@millenniumfalcon ~/dev/snyk/snyk ‹node@v8.12.0› ‹npm@6.9.0› ‹fix/snyk-help›

https://github.com/snyk/snyk/pull/566/files#diff-68eee24119fcbc98afbd4d408550f212R17 needs to return

@kyegupov
Copy link
Contributor Author

@orsagie @miiila derp. Fixed.

@kyegupov kyegupov merged commit 0babc68 into master Jun 10, 2019
@kyegupov kyegupov deleted the fix/snyk-help branch June 10, 2019 10:58
@snyksec
Copy link

snyksec commented Jun 10, 2019

🎉 This PR is included in version 1.174.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Mar 30, 2023
Open
@Jimimaku Jimimaku mentioned this pull request Jun 20, 2023
Open
This was referenced Jun 20, 2023
Closed
Closed
This was referenced Jun 20, 2023
Open
Open
@sapans30 sapans30 mentioned this pull request Jun 20, 2023
Open
@logangeorgebrown logangeorgebrown mentioned this pull request Jun 20, 2023
Closed
@allRounderWiser allRounderWiser mentioned this pull request Jun 20, 2023
Open
This was referenced Jun 20, 2023
Closed
Closed
Closed
Closed
@romathur romathur mentioned this pull request Jun 20, 2023
Open
@logangeorgebrown logangeorgebrown mentioned this pull request Jun 20, 2023
Closed
@robin-qualityengineer robin-qualityengineer mentioned this pull request Jun 20, 2023
Open
@romathur romathur mentioned this pull request Jun 20, 2023
Open
@logangeorgebrown logangeorgebrown mentioned this pull request Jun 20, 2023
Closed
@hiep98 hiep98 mentioned this pull request Jun 20, 2023
Open
@jeremy001181 jeremy001181 mentioned this pull request Jun 21, 2023
Open
@logangeorgebrown logangeorgebrown mentioned this pull request Jun 21, 2023
Closed
@mmmd03 mmmd03 mentioned this pull request Jun 21, 2023
Open
@logangeorgebrown logangeorgebrown mentioned this pull request Jun 21, 2023
Closed
@froscheimer froscheimer mentioned this pull request Jun 21, 2023
Open
@RyanPHigh RyanPHigh mentioned this pull request Jun 21, 2023
Open
@romathur romathur mentioned this pull request Jun 21, 2023
Open
@RyanPHigh RyanPHigh mentioned this pull request Jun 21, 2023
Open
@logangeorgebrown logangeorgebrown mentioned this pull request Jun 21, 2023
Closed
@romathur romathur mentioned this pull request Jun 21, 2023
Open
@RyanPHigh RyanPHigh mentioned this pull request Jun 21, 2023
Open
@mikolajroszak mikolajroszak mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 21, 2023
Open
@RyanPHigh RyanPHigh mentioned this pull request Jun 21, 2023
Open
@romathur romathur mentioned this pull request Jun 22, 2023
Open
@logangeorgebrown logangeorgebrown mentioned this pull request Jun 23, 2023
Closed
@mikolajroszak mikolajroszak mentioned this pull request Oct 16, 2023
Open
@gitworkflows gitworkflows mentioned this pull request Jan 19, 2024
Open
@claireksnyk claireksnyk mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsagie orsagie orsagie left review comments

@miiila miiila miiila approved these changes

Assignees

@kyegupov kyegupov

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyegupov @miiila @snyksec @orsagie