fix: fetch patch ignoring command line arguments #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
force-pushed
the
fix/fetch-patch-use-request
branch
from
c39c42e
to
f060530
Compare
miiila
suggested changes
Oct 10, 2019
| @@ -1,89 +0,0 @@ | |||
| var test = require('tap').test; | |||
There was a problem hiding this comment.
I don't see this test being migrated. Is it desired?
There was a problem hiding this comment.
it's covered by the new request.test.ts
There was a problem hiding this comment.
Cool. And could we get back all the cases describe in https://github.com/snyk/snyk/pull/813/files#diff-f932f6df5ce16fc0d2438970c1daabd0L39? Or do you think it's not necessary?
There was a problem hiding this comment.
Sure I can add tests using http_proxy and no_proxy
gitphill
force-pushed
the
fix/fetch-patch-use-request
branch
from
f060530
to
1d45215
Compare
miiila
approved these changes
Oct 10, 2019
BST-889 Fetch patch was making http requests by using needle directly Changed to use lib request which uses command line arguments when invoking needle Added tests for lib request Changed fetch patch fail test to typescript Removed patch fetch proxy test (now covered by lib request test) Added @types/sinon devDependency to help write test with sinon assertions and matchers
gitphill
force-pushed
the
fix/fetch-patch-use-request
branch
from
1d45215
to
c7bcc89
Compare
|
🎉 This PR is included in version 1.234.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BST-889
Fetch patch was making http requests by using needle directly
Changed to use lib request which uses command line arguments when invoking needle
Added tests for lib request
Changed fetch patch fail test to typescript
Removed patch fetch proxy test (now covered by lib request test)
Added @types/sinon devDependency to help write test with sinon assertions and matchers
What does this PR do?
Fix issue when snyk protect run as part of snyk wizard and doesn’t keep the --insecure flag
Module fetch-patch was using needle directly
I've changed to use lib/request which handles command line arguments like --insecure
How should this be manually tested?
Run
DEBUG=* snyk wizard --insecureagainst a project where a patch can be applied. Notice that fetch patch does not use insecure flag and should result in needle using rejectUnauthorized option.What are the relevant tickets?
BST-889
Screenshots