feat: detect *.jar files as maven #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
force-pushed
the
feat/introduce-jar-files
branch
2 times, most recently
from
f1ee1be
to
f12c39a
Compare
lili2311
force-pushed
the
feat/introduce-jar-files
branch
3 times, most recently
from
48d9865
to
345909d
Compare
lili2311
commented
Nov 12, 2019
| @@ -26,3 +80,92 @@ test('`protect` should not fail for unauthorized users', (t) => { | |||
| userConfig.set('api', apiUserConfig); | |||
| }); | |||
| }); | |||
|
|
|||
| test('`protect` for unsupported package managers', async (t) => { | |||
There was a problem hiding this comment.
copied these over from main acceptance test
orsagie
reviewed
Nov 12, 2019
| @@ -40,6 +40,7 @@ const DETECTABLE_PACKAGE_MANAGERS: { | |||
| '.gemspec': 'rubygems', | |||
| 'package-lock.json': 'npm', | |||
| 'pom.xml': 'maven', | |||
| '.jar': 'maven', | |||
There was a problem hiding this comment.
I think we also want to detect .war
There was a problem hiding this comment.
let's add the rest as the user requests for this, added jar and war. Each one will need tests etc, so let's get 1/2 working end to end
orsagie
reviewed
Nov 12, 2019
| @@ -0,0 +1,1584 @@ | |||
| import * as tap from 'tap'; | |||
lili2311
force-pushed
the
feat/introduce-jar-files
branch
from
345909d
to
40bf99a
Compare
lili2311
force-pushed
the
feat/introduce-jar-files
branch
from
40bf99a
to
0189a39
Compare
orsagie
approved these changes
Nov 13, 2019
|
🎉 This PR is included in version 1.247.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
*.jarfiles to be processed by the mvn pluginWhat are the relevant tickets?
BST-1044