Chore/convert test to typescript #897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
force-pushed
the
chore/convert-test-to-typescript
branch
from
8ca1cee
to
1f5d701
Compare
Converting snyk test to typescript. Co-authored-by: Lili Kastilio <lili@lilianakastilio.co.uk>
gitphill
force-pushed
the
chore/convert-test-to-typescript
branch
from
fbc0cb3
to
4377ae5
Compare
|
abandoning this for now, error handling is broken seems too risky to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Convert test to typescript
Additional questions
Couldn't see anywhere that used callback function, so I've removed.