Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing quote in README.md sample #97

Closed
wants to merge 1 commit into from

Conversation

koczkatamas
Copy link

@koczkatamas koczkatamas commented Jul 19, 2017

The closing " was missing from the data-canonical-src attribute in the HTML badge sample code.

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Fix a typo.

Where should the reviewer start?

Github changes window.

How should this be manually tested?

It's just a typo.

Any background context you want to provide?

No.

What are the relevant tickets?

None.

Screenshots

Nope.

Additional questions

I hereby give permission to use my such great contribution to the project without signing a CLA. Seriously, I hope you'll make an exception in the CLA for small changes like this one...

The closing `"` was missing from the `data-canonical-src` attribute in the HTML badge sample code.
@CLAassistant
Copy link

CLAassistant commented Jul 19, 2017

CLA assistant check
All committers have signed the CLA.

@adrukh
Copy link
Contributor

adrukh commented Jul 19, 2017

@koczkatamas thanks for this small but important fix!
We will include it in our next cli release cycle.

adrukh pushed a commit that referenced this pull request Jul 27, 2017
@maban
Copy link
Contributor

maban commented Sep 14, 2017

Closing as this has been fixed!

@maban maban closed this Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants