Merge pull request #401 from cloudskiff/issue_375_lotoussa

Fix aws_route53_record error when deserializing resource (null value is not allowed)
snyk · Apr 1, 2021 · 3f8d5e0 · 3f8d5e0
2 parents ebfeb0b + d4b3b4c
commit 3f8d5e0
Show file tree

Hide file tree

Showing 11 changed files with 171,921 additions and 14 deletions.
diff --git a/pkg/iac/terraform/state/terraform_state_reader_test.go b/pkg/iac/terraform/state/terraform_state_reader_test.go
@@ -49,6 +49,7 @@ func TestTerraformStateReader_AWS_Resources(t *testing.T) {
 		{name: "Route 53 zone", dirName: "route53_zone", wantErr: false},
 		{name: "Route 53 record - single record", dirName: "route53_record", wantErr: false},
 		{name: "Route 53 record - multiples zones, multiples records", dirName: "route53_record_multiples", wantErr: false},
+		{name: "Route 53 record - empty records", dirName: "route53_record_null_records", wantErr: false},
 		{name: "s3 full", dirName: "s3_full", wantErr: false},
 		{name: "RDS DB instance", dirName: "db_instance", wantErr: false},
 		{name: "RDS DB Subnet group", dirName: "db_subnet_group", wantErr: false},

diff --git a/pkg/iac/terraform/state/test/route53_record_null_records/result.golden.json b/pkg/iac/terraform/state/test/route53_record_null_records/result.golden.json
@@ -0,0 +1,20 @@
+[
+ {
+  "AllowOverwrite": true,
+  "Fqdn": "foo-0.com",
+  "HealthCheckId": "",
+  "Id": "Z1035360GLIB82T1EH2G_foo-0.com_NS",
+  "MultivalueAnswerRoutingPolicy": null,
+  "Name": "foo-0.com",
+  "Records": null,
+  "SetIdentifier": "",
+  "Ttl": 172800,
+  "Type": "NS",
+  "ZoneId": "Z1035360GLIB82T1EH2G",
+  "Alias": null,
+  "FailoverRoutingPolicy": [],
+  "GeolocationRoutingPolicy": [],
+  "LatencyRoutingPolicy": [],
+  "WeightedRoutingPolicy": []
+ }
+]